Media Ranker

danimetz · 2018-10-15T09:10:06Z

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I created a method in the works model to determine what the "Spotlight" media was. It is a class method that returns the piece of work that has the highest number of votes.
Describe how you approached testing that model method. What edge cases did you come up with?	The edge cases I came up with were what if there was a tie? What if none of the works have votes yet.
What are `session` and `flash`? What is the difference between them?	We use flash to send one-time messages from our controllers to our views. Session is similar to flash except that the data is stored in the cookies and will not be gone after the user clicks somewhere else. The session data will be gone once the browser is closed.
Describe a controller filter you wrote.	I wrote a two controller filters one in the application controller to determine the current user from all pages, this was necessary in order to keep track of the users votes during their session. I also created a find_work controller filter in the works controller to DRY up some of the methods in the works controller.
What was one thing that you gained more clarity on through this assignment?	I gained better clarity on tests, and using session and flash messages.
What is the Heroku URL of your deployed application?	https://media-ranker-dani.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Overall I enjoyed it! The CSS took way longer than I was anticipating. It was a good way to really nail down how session and flash work.

…rors will appear on webpage

…d across all the way

… for select, and the second for html options. So all you need is to give default empty options as first param after list of items and then add your class to html_options. This fixed the category drop down to be the entire width of the container

…rails destroy controller

CheezItMan · 2018-10-24T00:50:43Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check, I'm glad you gained some clarity with tests.
General
Rails fundamentals (RESTful routing, use of named paths)	Not all your routes are needed, check the `UsersController`.
Views are well-organized (DRY, use of semantic HTML, use of partials)	You could make better use of partials, and you don't have flash notices on `update` actions for `WorksController`.
Business logic lives in the models	You've got some business logic methods here. Nice work.
Models are thoroughly tested, including relations, validations and any custom logic	You do have some bugs in testing relationships. You also have some spotty testing in your custom methods. I realize the code is almost a copy-paste, but you can't test like that will always be the case.
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Wave 3 - Users and Votes
Media pages contain lists of voting users	Check
Individual user pages and the user list are present	Check
Optional - Styling
Bootstrap is used appropriately	Very nice work with Bootstrap
Look and feel is similar to the original	Very good job imitating the original
Overall	Overall, nice work, you hit all the learning goals. Areas for improvement include some testing, and using partials where you can. Still, you did a good job.

CheezItMan · 2018-10-24T00:29:07Z

config/routes.rb

+Rails.application.routes.draw do
+  root 'works#main'
+  resources :works
+    post 'works/:id/upvote', to: 'works#upvote', as: 'upvote'


The indentation doesn't actually mean anything here as it's not technically nested inside.

CheezItMan · 2018-10-24T00:29:42Z

config/routes.rb

+  resources :works
+    post 'works/:id/upvote', to: 'works#upvote', as: 'upvote'
+
+  resources :users


Do you need all the CRUD route for users? What about :edit and :update?

CheezItMan · 2018-10-24T00:34:07Z

test/models/work_test.rb

+      vote = work.votes
+
+      # Assert
+      expect(vote).must_be_instance_of Vote


because vote here is actually a collection of votes, this test failed. If you wanted to test the type you could loop through the collection and check that each instance is a Vote.

Also since a Work has many votes, it doesn't have a foreign key in it.

Instead expect(vote.work_id).must_equal work.id

CheezItMan · 2018-10-24T00:42:33Z

test/models/work_test.rb

+  end
+
+  describe 'Media Page - Methods' do
+    it 'return top 10 of a given category' do


You're not throughly testing all the methods here. Just top_movies for 10 items and more than 10 and top_books for less than 10. You don't test each.

CheezItMan · 2018-10-24T00:43:19Z

test/models/user_test.rb

+    end
+  end
+
+  describe "Validations" do


No user validations?

What about tests for date_joined

CheezItMan · 2018-10-24T00:44:22Z

app/models/user.rb

+class User < ApplicationRecord
+  has_many :votes
+  has_many :works, through: :votes
+


No validations? What about username?

CheezItMan · 2018-10-24T00:47:04Z

app/controllers/works_controller.rb

+  def update
+    if @work && @work.update(work_params)
+      redirect_to work_path(@work.id)
+    elsif @book


No flash.now notices?

CheezItMan · 2018-10-24T00:49:50Z

app/views/works/index.html.erb

+  </tr>
+</thead>
+<tbody>
+  <% @works.each do |work| %>


Notice that you do a very similar table here a lot. You could DRY this out with a partial.

danimetz added 30 commits October 8, 2018 13:55

Initial Rails setup

1263a72

Created works model

4c41d78

Successfully seeded data

7a4fc3a

Added routes for Work

b382081

Added action methods to the controller

e763932

Created votes and users models and controllers

e1850d3

Added controllers and models for users and votes

3e5c50b

Added action_view.rb file in confi/initializers so that validation er…

717b86b

…rors will appear on webpage

Updated view for work index

3d15934

Added main and index pages for all the works

e07d065

Created partial view for form to update & create new works

721eaba

Added view for work show

ee0f2e6

Added flash error messages

db7c51b

Wrote validation and valid tests for work model

21ba04c

Cleaned up work controller with filters

67add20

Added ability to login and out

b0f6edd

Added upvote route to route.rb

a7c8b70

Added validations to votes model

7c7637d

Added validations to votes model

5754ef7

Created upvote method

44a2342

Added CSS from website

56850fd

Finished updating work show page

65fe6e6

Fixed form for edit and create new works, can't get category to sprea…

a4fca5e

…d across all the way

Added saved form

fe07c80

Updated HTML for users index page

900abb1

Fixed spotlight page to have correct formatting

38c6795

Removed Votes controller because no views are shown for votes, using …

dc508df

…rails destroy controller

Cleaned up CSS

36f309c

Updated routes

e1210d0

danimetz added 6 commits October 15, 2018 01:08

Unsuccessfully tried to get the owl logo to show up on the tab

437c176

Successfully deployed, updated username form

96a95f8

Added a bug in the form, needed ot add an extra comma

6122bd1

Added extra alert class to flash messages div

96289f5

Updated tests for user and votes

cd7e52b

Added more tests to work model

0fd484c

CheezItMan reviewed Oct 24, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Media Ranker - Danielle#32

Media Ranker - Danielle#32
danimetz wants to merge 36 commits intoAda-C10:masterfrom
danimetz:master

danimetz commented Oct 15, 2018

Uh oh!

CheezItMan commented Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

CheezItMan Oct 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

danimetz commented Oct 15, 2018

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented Oct 24, 2018

Media Ranker

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants