Open
Conversation
added 17 commits
October 11, 2018 16:29
Media RankerWhat We're Looking For
|
CheezItMan
reviewed
Oct 23, 2018
|
|
||
| root "welcome#index" | ||
|
|
||
| resources :users |
There was a problem hiding this comment.
Do you really need all routes for each of these controllers? Limit the routes to only the ones you're using.
Example:
resources :users, only: [:index, :show]| fields = [:movie, :book, :album ] | ||
|
|
||
| fields.each do |field| | ||
| expect(vote).must_respond_to field |
There was a problem hiding this comment.
This test is failing because votes don't have a separate field for the different categories, it should be:
fields = [:work, :user]| let(:vote) { Vote.new } | ||
|
|
||
| it "must be for a valid category" do | ||
| value(vote).must_be_kind_of :work |
There was a problem hiding this comment.
This doesn't make sense because votes aren't work.
| end | ||
|
|
||
| it 'user has the required fields' do | ||
| fields = [:user_name ] |
There was a problem hiding this comment.
You should also include the field :votes in this list.
| require "test_helper" | ||
|
|
||
| describe User do | ||
| let(:user) { users(:simple) } |
There was a problem hiding this comment.
You also need a validation test for user_name
| top_ten("movie") | ||
| end | ||
|
|
||
| def self.top_ten(category) |
There was a problem hiding this comment.
These are some great custom methods!
| <%= stylesheet_link_tag 'application', 'https://fonts.googleapis.com/css?family=Gudea:400,700|Hammersmith+One' %> | ||
| <%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %> | ||
| <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %> | ||
| <%= favicon_link_tag 'favicon.ico' %> |
There was a problem hiding this comment.
I'm not seeing this favicon in your files, so it's not running for me.
|
|
||
| <tr> | ||
| <td>25</td> | ||
| <td><a href="/works/134">The Hipster and the Beast</a></td> |
There was a problem hiding this comment.
Why were you hardcoding this here rather than using model data?
| <h2>Add a new work</h2> | ||
| <section> | ||
| <label>Category</label> | ||
| <select class="form-control" name="work[category]"><option value="album">album</option> |
There was a problem hiding this comment.
You are not using form_with or other Rails form controls.
|
|
||
| get "/:page" => "welcome#index" | ||
|
|
||
| get '/login', to: 'sessions#new' |
There was a problem hiding this comment.
You don't have a new method in your sessions controller.
CheezItMan
reviewed
Oct 27, 2018
| # Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html | ||
|
|
||
| one: | ||
| category: movie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?