LJ: nodes : media ranker by elle-johnnie · Pull Request #47 · Ada-C10/MediaRanker

elle-johnnie · 2018-10-15T20:56:18Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I created a method in my works model to return the top 10 works. The category of the work is passed in as parameter in the method the method then collects all the works within that category orders them by their votes_count value in descending order then returns the first 10 objects within that array.
Describe how you approached testing that model method. What edge cases did you come up with?	An edge case is an instance where no works are within that category and the view reflects no works found by that category. A nominal case is that it returns a list with the highest ranking vote count as the first item in the list. Another nominal case verifies that 10 items are returned.
What are `session` and `flash`? What is the difference between them?	Session stores login data for a user in the browser's cookies and keeps track of them per session. Flash notices are one time messages sent to the user typically indicating success, failures, or warnings in the view.
Describe a controller filter you wrote.	I utilized a find filter to get a work by its id. This filter was run before create, update, show, and destroy methods in the works controller.
What was one thing that you gained more clarity on through this assignment?	I learned a little bit about caching as well as using Factory Bot to generate test data, which was pretty cool.
What is the Heroku URL of your deployed application?	https://dashboard.heroku.com/apps/ljs-mediaranker-app
Do you have any recommendations on how we could improve this project for the next cohort?	I struggled a lot with matching the styling using the copy paste method - once I reverted back to styling via bootstrap approximations I found it easier. It was hard to get motivated to just copy and paste. -- Things still to learn: I have lingering questions about database optimization - loading data always seems a bit slow so it makes me think I could be implementing methods that speed up data retrieval and queries. It would be good to have a class discussion on this.

…es for works and users

dHelmgren · 2018-10-24T20:17:17Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Yes!
Comprehension questions	yes!
General
Rails fundamentals (RESTful routing, use of named paths)	Mostly, see comment!
Views are well-organized (DRY, use of semantic HTML, use of partials)	yes
Errors are reported to the user	yes!
Business logic lives in the models	yes
Models are thoroughly tested, including relations, validations and any custom logic	You only tested your CRUD, but you wrote custom logic that needed validation!
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	no, splash page is not, but you have it working on the all media page.
Splash page contains a media spotlight	Yes
Wave 3 - Users and Votes
Media pages contain lists of voting users	yes
Individual user pages and the user list are present	yes
Optional - Styling
Bootstrap is used appropriately	yes
Look and feel is similar to the original	Yeah, great work!
Overall	Great job overall! Your implementation matches the demo site very closely, and I would say the learning goals for this assignment were definitely met. There are a few places where things could be cleaned up, which I've tried to outline below, but in general I am quite happy with this submission. Keep up the hard work!

dHelmgren · 2018-10-24T19:56:30Z

config/routes.rb

+Rails.application.routes.draw do
+  root "works#index"
+
+  resources :users


I don't think you need all 7 restful routes for users - only index and show are needed for this project.

dHelmgren · 2018-10-24T20:08:56Z

app/views/works/_top.html.erb

+      <% if cat_list.empty? %>
+        <h4>No <%=cat.pluralize%> have been added to the database.</h4>
+      <% else %>
+        <% cat_list.each do |item| %>


Nice work on this! very DRY and clean

dHelmgren · 2018-10-24T20:10:12Z

app/models/work.rb

+  has_many :users, through: :votes
+
+  # validation
+  CATS = %w(album movie book)


Nice work here, this keeps your code very clean.

dHelmgren · 2018-10-24T20:12:17Z

test/controllers/votes_controller_test.rb

+    get votes_create_url
+    value(response).must_be :success?
+  end
+


You should be testing the uniqueness constraint here! Specific test cases I'd want to see:

A user can have votes for two different works

A work can have votes from two different users

A user cannot vote for the same work twice

dHelmgren · 2018-10-24T20:13:49Z

app/models/work.rb

+  end
+
+  def self.spotlight?
+    spot = self.all.sample


Gotta sort them too!

dHelmgren · 2018-10-24T20:14:59Z

app/models/work.rb

+  # pub year must be number in year range 0 - 2018
+  validates :publication_year, numericality: true, inclusion: 0..2018
+
+  def self.top?(category)


the question mark here has a semantic meaning that you aren't using correctly. A question mark at the end of a method signature implies that it returns a boolean.

dHelmgren · 2018-10-24T20:16:22Z

test/controllers/works_controller_test.rb

+      delete work_url(work)
+    }.must_change "Work.count", -1
+
+    must_redirect_to works_path


There's a lot of interesting test cases for your custom Work methods missing here. For top?, I would wonder:

What happens if there are no works?

What happens if there are works but no votes?

What happens if two works have the same number of votes?

Similarly for your 'sample' method, I would ask:

What if there are no works of that category?

What if there are less than 10 works?

What if there's a tie for last place, e.g. works 9, 10 and 11 all have 0 votes?

elle-johnnie added 30 commits October 8, 2018 14:31

initial rails setup

1f38c73

create Works contoller

8e21f35

tried generate scaffold for Work

a1497f2

created seeds.rb and seeded db

ed315c8

work model validations and tests

e3fc991

added guard and minitest gems

42af3db

added set default form_with

47c30f0

added some flash verification for create work

9307595

session controller created

4b34d9a

session routes and actions created

bef2d63

enabled login logout for user

c3d3bb5

setup vote relationship model to user and work

cba26f7

vote tests

dd4ddd9

changed pub year col to integer, fixed date issues throughout

c20f1a6

testing

af00348

votes controller added

0393dd1

Merge branch 'votes'

9fb2d3c

votes routes

b53031d

resolved merge conflicts

8f3e7b4

vote test mods still not creating new in test

0514ce0

added before action filter

9eb8cd8

vote test valid good

a973458

vote validation tests added

0e8418c

upvote method created in works controller

6f4cfda

flash msg if a user tries to vote more than once for a work

88dd731

edits for heroku run

4a65bc0

more edits for heroku run

1fa84b5

more edits for heroku run

9b014f7

favicon moved to public for heroku

87cf664

nav links created

fc263c0

elle-johnnie added 20 commits October 12, 2018 11:23

counter cache built for votes for more efficient vote count querying

452cb13

top ten works method

7dd8bdb

oops added relationship tests on css branch

2299cdc

view index tables created

7378f29

css styling

95c53d9

favicon bug

bfb86af

flash and css fixes

fa04a0b

ico

4de5dae

comment out rm col vote_count to fix heroku migration

6d05569

fixed login bug

0d1a7b5

fixed login css

49ac0ab

works and users not found fixed

a6a03a4

rm unnecesary file

efc2ee5

file cleanup complete

5192717

created and cleaned up partials

490048f

tests cleanup

a1a0bfa

factory bot created for some additional test data in works model

e46866a

heroku custom 404 not showing

ee70878

config initializer assets.rb fixed to render custom 404 not found pag…

0160ab9

…es for works and users

modify jpg to try and render in heroku

12a7034

dHelmgren reviewed Oct 24, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LJ: nodes : media ranker#47

LJ: nodes : media ranker#47
elle-johnnie wants to merge 50 commits intoAda-C10:masterfrom
elle-johnnie:master

elle-johnnie commented Oct 15, 2018 •

edited

Loading

Uh oh!

dHelmgren commented Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

dHelmgren Oct 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

elle-johnnie commented Oct 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Media Ranker

Comprehension Questions

Uh oh!

dHelmgren commented Oct 24, 2018

Media Ranker

What We're Looking For

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

elle-johnnie commented Oct 15, 2018 •

edited

Loading