Laura MediaRanker by lauracodecreations · Pull Request #49 · Ada-C10/MediaRanker

lauracodecreations · 2018-10-15T22:21:12Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I create the joining_date method to define the date by calling the created_at attribute, and in addition, I formatted the date.
Describe how you approached testing that model method. What edge cases did you come up with?	I plan to continue working on this. I did test my work model validations
What are `session` and `flash`? What is the difference between them?	session allows users to log in, flash is a message that flashes the user if the
Describe a controller filter you wrote.	not yet
What was one thing that you gained more clarity on through this assignment?	how to debug errors in rails when the 'raise' does not work, how to create a custom method in the model, and how to test validations.
What is the Heroku URL of your deployed application?	https://media-app-2018.herokuapp.com/users/1
Do you have any recommendations on how we could improve this project for the next cohort?	maybe learning how to use pry to test the params in the rails app while is running would be helpful for other students when debugging syntax errors. A tutor taught me how to use pry to stop the rails in a method and test if the syntax is correct (the webpage will not change move unless I exit pry). This helped a lot when debugging errors because it was more efficient than writing all info from params in the rails console.

…er below 2019

…egory.......... validations?

Votes and users

dHelmgren · 2018-10-23T20:39:14Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good
Comprehension questions	Yes
General
Rails fundamentals (RESTful routing, use of named paths)	Generally good, see comments
Views are well-organized (DRY, use of semantic HTML, use of partials)	Mostly true, but see comments!
Errors are reported to the user	Yes
Business logic lives in the models	Business logic is missing.
Models are thoroughly tested, including relations, validations and any custom logic	Tests could be more robust.
Wave 1 - Media
Splash page shows the three media categories	No
Basic CRUD operations on media are present and functional	Mostly, but there are a few bugs, see comments.
Wave 2 - Users and Votes
Users can log in and log out	Yes
The ID of the current user is stored in the session	Yes!
A user cannot vote for the same media more than once	Yes, but see comments
All media lists are ordered by vote count	No.
Splash page contains a media spotlight	No.
Wave 3 - Users and Votes
Media pages contain lists of voting users	No.
Individual user pages and the user list are present	Yes
Optional - Styling
Bootstrap is used appropriately	Yes!
Look and feel is similar to the original	No, but not important
Overall	The parts of the project that you were able to finish work very well and are cleverly designed, but it feels to me like you ran out of time. If there is anything I would suggest that you practice, it's writing business logic similar to the Top Ten code that was required for this project. Keep up the good work!

dHelmgren · 2018-10-23T20:22:35Z

config/routes.rb

+  get 'users/create'
+  get 'users/new'
+  get 'users/show'
+  get 'users/destroy'


I don't think you need all these routes for users - only index and show are needed for this project.

dHelmgren · 2018-10-23T20:25:19Z

app/views/works/index.html.erb

+<% @album.each do |work| %>
+<tr>
+  <td><%=work.votes.length%></td>
+  <td><%= link_to "#{work.title}", work_path(work.id) %></td><td>


You have the same code to show a list of works repeated 3 times. Could you use a view partial or a loop to DRY this up?

dHelmgren · 2018-10-23T20:28:36Z

app/models/vote.rb

@@ -0,0 +1,6 @@
+class Vote < ApplicationRecord
+  validates :user, uniqueness: { scope: :user_id,
+    message: "should happen once per user" }


I think you misinterpreted the request we had. We wanted person to be able to vote for more than one work, but we didn't want users to be able to vote for a single work more than once.

Put another way, if I upvote DAMN by Kendrick Lamar, I can still upvote Titanic, but I can't vote for DAMN again.

dHelmgren · 2018-10-23T20:31:45Z

app/models/work.rb

@@ -0,0 +1,8 @@
+class Work < ApplicationRecord
+  has_many :votes
+  CATEGORIES = %w(album book movie)


Nice job with this, you can actually leverage this EVEN MORE! Think about what this gives you on your works/index page!

dHelmgren · 2018-10-23T20:35:18Z

test/models/vote_test.rb

+
+  it "must be valid" do
+    value(vote).must_be :valid?
+  end


You should be testing the uniqueness constraint here! Specific test cases I'd want to see:

A user can have votes for two different works

A work can have votes from two different users

A user cannot vote for the same work twice

dHelmgren · 2018-10-23T20:36:52Z

test/models/work_test.rb

+        expect(work).must_equal :valid?
+      end
+    end
+


This is where I would expect tests for the code that picks your top 10 works to live.

For implementing those I would wonder:

What happens if there are no works?

What happens if there are works but no votes?

What happens if two works have the same number of votes?

Similarly for you category and top ten methods, I would ask:

What if there are no works of that category?

What if there are less than 10 works?

What if there's a tie for last place, e.g. works 9, 10 and 11 all have 0 votes?

lauracodecreations added 30 commits October 8, 2018 14:07

Initial Rails setup

4529f91

create work model

3cb69b3

created seeds file

b496496

create test data and validation test

63cbefe

create test for validating title:

95493fb

create creator validation and tests for it

10d2bc7

create validation ffor published year and tests for it

ca89382

create a validation for categories and test for it

211648e

create session controller

3500749

create routes to use for session

67ede72

add new user method for a new session

89b1ac2

create home page

6050894

fixed error about node.js by updating it's version

a4e6f7f

create work controller

3608189

Merge branch 'master' into workmodel

fa35b50

list all media

9226745

uncomment root path

40e7a54

create show page and method for each media

1fb1e26

create edit method and view page

78b43bc

inform user of errors when editing or saving a work

1273aeb

allow user to edit or delete works from homepage

40663fe

add link to homepage

03bfb16

edit and delete actions

a4fae99

inform user if work was created sucessfully

b2815bc

this outputs validations errors to user

a90ee2d

change datatype of year from string to integer and restrict only numb…

c207dc4

…er below 2019

moved controller actions from view page

08dea59

crate vote and user model

a271721

set up relationships between user and votes, and votes and work

b52e2ea

allow user to vote only once in a work

5b76330

lauracodecreations added 14 commits October 12, 2018 15:28

create user controller

a61d8fc

log in works, but log out doesn't

2dbc9bc

fixed logout

3109107

fixed flash notices to show when user is new or existing

a197b7d

create route for upvote

6e77e34

created upvote button in the work index page

da02620

create upvote method and show the number of votes in the work index page

7a0eaa5

upvote method works, but the user can only time per work, not per cat…

705ab88

…egory.......... validations?

refactor routes

0546341

remove unnecessary comments

3e347bf

show page for users

bf354dc

Merge pull request #2 from lauramar6261/votes

f8a7be3

Votes and users

removed pry

a16a0ee

format date for user joining date

0a3cb79

dHelmgren reviewed Oct 23, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Laura MediaRanker#49

Laura MediaRanker#49
lauracodecreations wants to merge 44 commits intoAda-C10:masterfrom
lauracodecreations:master

lauracodecreations commented Oct 15, 2018

Uh oh!

dHelmgren commented Oct 23, 2018

Uh oh!

dHelmgren Oct 23, 2018

Uh oh!

dHelmgren Oct 23, 2018

Uh oh!

dHelmgren Oct 23, 2018

Uh oh!

dHelmgren Oct 23, 2018

Uh oh!

dHelmgren Oct 23, 2018

Uh oh!

dHelmgren Oct 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lauracodecreations commented Oct 15, 2018

Media Ranker

Comprehension Questions

Uh oh!

dHelmgren commented Oct 23, 2018

Media Ranker

What We're Looking For

Uh oh!

dHelmgren Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

dHelmgren Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants