Open
Conversation
… color to initialized variables in planet.rb
…create solar system instance and additional planets
…d fixed bugs in control loop in main
|
Good job overall - this submission is well-organized and clearly hits the learning goals. Keep up the hard work! |
droberts-sea
reviewed
Mar 7, 2019
| solar_system = SolarSystem.new("Sol") | ||
| mercury = Planet.new("Mercury", "dark grey", 3.285e23, 5.791e7, "Named for the messenger of the Roman gods due to its orbital speed") | ||
| solar_system.add_planet(mercury) | ||
| venus = Planet.new("Venus", "red-brown", 4.867e24, 1.082e8, "Both the morning star and the evening star") |
There was a problem hiding this comment.
You should wrap all this work in a main method.
| def user_adds_planet | ||
| puts "Please complete the following information for the planet you would like added: \nName: " | ||
| name = gets.chomp.capitalize | ||
| puts "Color: " |
There was a problem hiding this comment.
I like that you've broken this out as a separate method. Since this method interacts with the user, it might fit better in main.rb, possibly taking the solar system as an argument.
| def distance_between_by_input | ||
| puts "Please enter the two planets you would like to find the distance between:" | ||
| print "Planet 1: " | ||
| planet1 = self.find_planet_by_name(gets.chomp) |
There was a problem hiding this comment.
As above, it might make sense to split the user interaction pieces of this out into a separate method in main.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod run? What does it do?Hashinstead of an instance of a class?SolarSystemclass used aHashinstead of anArrayto store the list of planets?requirestatements? Which files neededrequires, and which did not? What is the pattern?