Open
Conversation
|
Good job overall - this submission is well-organized and clearly hits the learning goals. Keep up the hard work! |
droberts-sea
reviewed
Mar 6, 2019
|
|
||
| solar_system.planets.each_with_index do |planet, index| | ||
| puts "#{planet.name}" | ||
| if planet.name == learn_choice |
There was a problem hiding this comment.
Please remove debug output (like line 37) before submitting projects.
| def find_planet_by_name(planet_name) | ||
| @planets.each do |planet| | ||
| if planet.name.capitalize == planet_name.capitalize | ||
| return planet |
There was a problem hiding this comment.
Is there an enumerable method you could use to make this a little cleaner?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod run? What does it do?Hashinstead of an instance of a class?SolarSystemclass used aHashinstead of anArrayto store the list of planets?requirestatements? Which files neededrequires, and which did not? What is the pattern?main.rbfile required the planet and solar system files because the data stored in each needed to be accessed by the main file. The solar system and planet files did not reference other sources because the information was self-contained.