Conversation
Solar SystemWhat We're Looking For
|
CheezItMan
reviewed
Mar 4, 2019
| sol_system.new_planet | ||
| puts sol_system.list_planets | ||
| end | ||
| break |
There was a problem hiding this comment.
This break is always going to make the loop exit.
| # @planets.name specify that you're searching the name | ||
| end | ||
|
|
||
| def list_planets_one |
There was a problem hiding this comment.
This method seems a duplication of the above
| end | ||
| end | ||
|
|
||
| def new_planet |
There was a problem hiding this comment.
This would be better as a method which takes a Planet as an argument and adds it to the planets array. That way you're separating the user-input task from the task of storing and organizing the planets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod run? What does it do?Hashinstead of an instance of a class?SolarSystemclass used aHashinstead of anArrayto store the list of planets?requirestatements? Which files neededrequires, and which did not? What is the pattern?