Ports - Shamira

[MiraMarshall]

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	The Model contains data for the app usually linked to a database. It contains business logic.
Describe in your own words what the Controller is doing in Rails	The Controller is the central manager of the Rails App. It gathers data from the model and passes the data to the view to be rendered as HTML.
Describe in your own words what the View is doing in Rails	The View turns data into HTML. It only displays the business logic and is similar to command line interfaces.
Describe an edge-case controller test you wrote	An example of edge cases I wrote were tests to check redirection for invalid input.
What is the purpose of using strong params? (i.e. the params method in the controller)	Strong params is a security measure to help prevent users from accessing model attributes.
How are Rails migrations related to Rails models?	The migrations create the schema(data table) that the models use to contain the state of the application.
Describe one area of Rails that are still unclear on	I'm interested in learning more about the Model and business logic. Instructors mentioned how we could use caching could store data. I would like to see how using something like that could make the App more interactive and mirror predictive behavior based on user actions.

[CheezItMan]

Task List

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in	You should have more commits, but you have good commit messages and no unnecessary files committed.
Answered comprehension questions	Check, well you'll get business logic in the project this week!
Successfully handles: Index, Show	Check
Index & Show tests pass	Check
Successfully handles: New, Create	Check
New & Create tests pass	Check
Successfully handles: Edit, Update	Check
Tests for Edit & Update test valid & invalid task ids	Check
Successfully handles: Destroy, Task Complete	Task complete isn't working, I left notes as to why
Tests for Destroy & Task Complete include tests for valid and invalid task ids	Your tests look good.
Routes follow RESTful conventions	Check
Uses named routes (like _path)	Check, well done
Overall	Nice work, you hit most of the learning goals for the project. See my notes on your mark complete route.

[CheezItMan]

This is a little weird. .save is a method, you shouldn't assign it a value.

It also crashes rails

[CheezItMan]

Why temporary redirect? why not server error or something?

[CheezItMan]

👍

[CheezItMan]

Nice confirmation

[CheezItMan]

This if statement is checking to see if the update method works or not, it doesn't check to see what complete_task.status is.

Instead I would do:

@complete_task = Task.find_by(id: params[:id])

if @complete_task
  @complete_task.status = ! @complete_task.status
  if @complete_task.save 
    redirect_to tasks_path
  else
     head :server_error
  end
else
  head :not_found
end

[CheezItMan]

This test is failing... Also you need to test that once you toggle a task to complete, you can toggle it incomplete.