Open
Conversation
CheezItMan
reviewed
Oct 4, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Ok, there's a bug with heap_down, see my comment on it and let me know any questions you have. Otherwise not bad. Also consider recursion and time complexity.
| else | ||
| min = [left, right].min_by {|x| @store[x].key} | ||
| end | ||
| swap(index, min) |
There was a problem hiding this comment.
This isn't quite working because you're not checking to see if the element at index is greater than the element at min.
if @store[index] > @store[min]
swap(index, min)
heap_down(min)
end| # Space Complexity: ? | ||
| # Time Complexity: 0(n log n) | ||
| # Space Complexity: 0(1) | ||
| def heap_sort(list) |
There was a problem hiding this comment.
This is not working due to a bug in heap_down
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: 0(log n) | ||
| # Space Complexity: 0(1) |
There was a problem hiding this comment.
Since heap_down is recursive you have to consider the impact of the recursion on space complexity.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: 0(log n) | ||
| # Space Complexity: 0(1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?