Open
Conversation
CheezItMan
reviewed
Oct 9, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work. Thanks for getting this in. Note my comments on heap_down and on your space complexity overall. You need to remember that recursion incurs some space complexity.
You hit the learning goals here, well done!
| while @store[index].key < @store[parent_index].key && parent_index > -1 | ||
| swap(index,parent_index) | ||
| index = parent_index | ||
| if index.odd? |
There was a problem hiding this comment.
Actually due to truncation it doesn't matter if the index is even or odd.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(logn) adding element to end of array is O(1) while heap-up worst case is O(logn) | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
Remember since your heap_up and heap_down methods are recursive, you have some space complexity from use of the system stack. So space complexity is O(log n)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?