Open
Conversation
CheezItMan
reviewed
Nov 8, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice work, I like how you used heapsort in place. You were also correct on all your time and space complexities. Well done.
| # Space Complexity: ? | ||
| # Time complexity: O(log(n)) | ||
| # Space complexity: O(1) | ||
| def remove() |
| # Space complexity: ? | ||
| # Time complexity: O(log(n)) | ||
| # Space complexity: O(1) | ||
| def heap_up(index) |
| end | ||
|
|
||
| # Time Complexity: O(n) => this is based of the math proof on geeks for geeks, not sure if I 100 % understand ... yet | ||
| # Space Complexity: O(n) <= can optimize by using iterative approach over recursion |
There was a problem hiding this comment.
Correct, you can optimize it a bit further using iteration.
| raise NotImplementedError, "Method not implemented yet..." | ||
| end No newline at end of file | ||
| # Time Complexity: O(nlogn) | ||
| # Space Complexity: O(n) |
There was a problem hiding this comment.
Correct by how you're using recursion to transform list into a heap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
CQs answered on previous pull request (closed)
heap_up&heap_downmethods useful? Why?Removed conflict =) For heap sort I wanted to try in place, otherwise I would have used the min heap, added each element to it then removed each element and pushed in to new list or index exisiting list 0 .. end to add elements.