Open
Conversation
CheezItMan
reviewed
Oct 4, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work! You hit all the learning goals here. Well done.
Comment on lines
+9
to
+15
| until list.empty? | ||
| minHeap.add(list.pop) | ||
| end | ||
|
|
||
| until minHeap.empty? | ||
| list << minHeap.remove | ||
| end |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n) - where n is the number of heap nodes | ||
| # Space Complexity: O(1) - constant |
There was a problem hiding this comment.
Since heap_up is recursive... You do have some space complexity here. The system stack.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n) - where n is the number of heap nodes | ||
| # Space Complexity: O(1) - constant |
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(log n) - where n is the number of heap nodes | ||
| # Space complexity: O(mn) - where m is the space the recursive call is taking up on the stack, and n is the max depth of the tree |
There was a problem hiding this comment.
Since m is likely to be constant in size, this is O(n)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?