Open
Conversation
CheezItMan
reviewed
Oct 4, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, except for the space complexity you hit the heap class well.
You don't have heapsort here. So... that's missing.
lib/min_heap.rb
Outdated
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n), where n is the number of levels in the heap | ||
| # Space Complexity: O(1), because there are no extra variables that change with input size |
There was a problem hiding this comment.
Since you have a recursive heap_up method, you have to consider the space complexity of that method. So... this is actually O(log n).
The same applies for all your recursive methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
nstands for the number of levels within the tree.heap_up&heap_downmethods useful? Why?