Open
Conversation
Faiza1987
approved these changes
Jun 11, 2019
| console.log(timelineData); | ||
|
|
||
| // Customize the code below | ||
| const postingData = timelineData.events.map ((post, i) => { |
There was a problem hiding this comment.
Great idea to just map in the App component!
|
|
||
| const Timeline = (props) => { | ||
|
|
||
| return( |
There was a problem hiding this comment.
Very clean and easy to see the flow of the data from timelineData.json
| } | ||
| const TimelineEvent = (props) => { | ||
|
|
||
| const time = <Timestamp time={ props.timeStamp} /> |
There was a problem hiding this comment.
Good idea to make use of the Timestamp component and saving its return value in a variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Timeline
Congratulations! You're submitting your assignment!
Comprehension Questions