Ports - Ngoc #3
Open
Ports - Ngoc #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 29, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, see my inline notes. You did miss the cost of some built-in Ruby methods, but overall very well done. I like your reverse in place!
| @@ -0,0 +1,16 @@ | |||
| def square_of_two(n) | |||
| # Space complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) |
There was a problem hiding this comment.
This is actually O(n^2) because s[0..s.length - 2] creates an entirely new string of length n-1.
|
|
||
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def reverse!(s, b, e) |
| end | ||
|
|
||
| # Time complexity: O(n) | ||
| # Space complexity: O(1) |
There was a problem hiding this comment.
Space complexity is O(n) due to the system stack.
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) |
There was a problem hiding this comment.
This one is O(n^2) for the same reasons as reverse, for both space & time
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) |
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) |
There was a problem hiding this comment.
O(n^2), think about how you solved reverse in place, could you use that technique to make this more efficient?
| return s[0] == s[s.length - 1] && is_palindrome(s[1..s.length - 2]) | ||
| end | ||
|
|
||
| # Time complexity: ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.