Ports-Elise&Sav

[ChubbyCub]

slack.rb

Congratulations! You're submitting your assignment!

You and your partner should collaborate on the answers to these questions.

Comprehension Questions

Question	Answer
How did you go about exploring the Slack API? Did you learn anything that would be useful for your next project involving an API?	We read the documentation and find out about the syntaxes for query parameters. We also try to make API calls from Postman to see if the get/post requests went through. We learned how to use Postman to test API calls and recognize the structure of the JSON objects that came back from the call.
Give a short summary of the request/response cycle. Where does your program fit into that scheme?	For our GET request, our program is the client that sends the request to the server (Slack API) to gather all information about channels and users. Once the Slack API received our request, it would return a response (in JSON format) to us.
How does your program check for and handle errors when using the Slack API?	We raised SlackError (a subclass of StandardError) whenever the response["ok"] is false. We wrapped the begin/rescue block around methods that make network calls to enhance users' experience.
Did you need to make any changes to the design work we did in class? If so, what were they?	We added an ApiWrapper module to contain all of our interaction with Slack API in this module.
Did you use any of the inheritance idioms we've talked about in class? How?	Yes, we added Recipient as our abstract class. Recipient contains template method (details) that must be implemented in our child classes (User and Channel). User and Channel inherited from Recipient (polymorphism)
How does VCR aid in testing a program that uses an API?	VCR enables us to record API responses so that we can reduce the number of API calls and run our tests offline.

[CheezItMan]

slack.rb

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene (no slack tokens)	Good number of commits and good commit messages
Comprehension questions	Check, glad you got to implement the abstract calss
Functionality
List users/channels	Check
Select user/channel	Check
Show details	Check
Send message	Check
Program runs without crashing	Check
Implementation
API errors are handled appropriately	Check, well done
Inheritance model matches in-class activity	For the most part, I like your API wrapper module.
Inheritance idioms (abstract class, template methods, polymorphism) used appropriately	Check, although you could take advantage of inheritance to define a send_message method that can work on either a channel or user.
Methods are used to break work down into simpler tasks	Very well broken down here
Class and instance methods are used appropriately	Check
Overall	Well done, you hit the learning goals on this project. I left some minor notes, but you did very well. I particularly like the wrapper module you created.

[CheezItMan]

I really like you having an API wrapper module here. It helps separate out the API from the rest of the app.

[CheezItMan]

Maybe this method would be better named list_channels.

[CheezItMan]

You could also have an abstract method called list which both user and Channel implement.

[CheezItMan]

You could also use .find here.

[CheezItMan]

These two describes have the same text.

[CheezItMan]

You should also verify that it returns the right format of data.

[CheezItMan]

You also need a test with an invalid channel.