Open
Conversation
CheezItMan
reviewed
Oct 2, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Some issue here with missing helper methods. Otherwise not bad. Take a look at my comments and let me know what questions you have.
Thanks for getting this in.
| current = @root | ||
| tree = [] | ||
|
|
||
| return inorder_helper(current, tree) |
There was a problem hiding this comment.
Did you forget to commit inorder helper? Ditto for the other traversals
| return height_helper(current, 1, 1) | ||
| end | ||
|
|
||
| def height_helper(node) |
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
Since you are doing recursion I would say this is O(log n) where n is the number of elements ,assuming it's a balanced tree. Remember doing recursion requires a stack!
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
Since you are doing recursion here, this is O(log n) assuming the tree is balanced. Remember the system stack used by recursion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.