Conversation
CheezItMan
reviewed
Sep 19, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
These methods work, but see my comments on the time complexity. Let me know if you have questions or if I can clarify a bit.
Well done!
| list.each_with_index do |value, index| | ||
| if index > 0 | ||
| if value == list[index - 1] | ||
| list.slice!(index) |
There was a problem hiding this comment.
Slice is going to shift subsequent elements to the left one index. Thus it as a time complexity of O(n). Inside this loop your method as time complexity of O(n2)
|
|
||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) |
There was a problem hiding this comment.
Since you have those two nested loops you actually have a time complexity of O(n2)
| end | ||
| return min_string if commons.length == strings.length | ||
|
|
||
| until hi <= low |
There was a problem hiding this comment.
Since you never change low, you may not need it. This made me think of binary search and it confused me for a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.