Conversation
CheezItMan
reviewed
Sep 19, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Daniela, can you leave your 1st name and class in the PR title.
Your 1st method works, see my note at the end. It's almost perfect except for that one thing. The 2nd method has an infinite loop
| end | ||
|
|
||
| current = 0 | ||
| until array_characters.length - 1 < current |
There was a problem hiding this comment.
you should also repeat until same is false.
| # Space Complexity: ? | ||
| # Time Complexity: n, as my algorithm needs to iterate through all elements. | ||
| # Space Complexity: n, as I'm creating an array to store the characters in each iteration. More elements, longer the new array. | ||
| def longest_prefix(strings) |
There was a problem hiding this comment.
You're getting stuck in an infinite loop here.
|
|
||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: n, as my algorithm needs to iterate through all elements. |
There was a problem hiding this comment.
I would say it's O(n) if the strings are small and O(m * n) where m is the length of the longest string if they're not.
dnsanche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished, but by some reason the tests stopped working. I had same issue last time with the last project for CS Fundamentals. I couldn't verify if the second exercise passed all tests. :(