Open
Conversation
CheezItMan
reviewed
Nov 14, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You're absolutely right something is better than nothing. You don't have many methods here, but factorial and reverse_in_place are well done.
| # Space complexity: ? | ||
| # Time complexity: O(n), because of the size of the stack (number of methods that is accumulated in the stack to run) | ||
| # Space complexity: O(n), because of the size of this stack | ||
| def factorial(n) |
Comment on lines
+20
to
+27
| while i < j | ||
| memo = s[i] | ||
| s[i] = s[j] | ||
| s[j] = memo | ||
|
|
||
| i += 1 | ||
| j -= 1 | ||
| end |
There was a problem hiding this comment.
A while loop, this is supposed to be recursive method 🤔
| # Time complexity: O(n) ~ n/2 as increasing and decreasing both pointer in same call | ||
| # Space complexity: O(n), n/2 recursive calls, | ||
| # because both pointers are moving each time the method is called | ||
| def reverse_inplace(s, i = 0, j = s.length - 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better something than nothing...