Conversation
CheezItMan
reviewed
Nov 20, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work, you hit the learning goals here. Well done.
Comment on lines
+21
to
+23
| new_solution = first_solution + second_solution | ||
| second_solution = first_solution | ||
| first_solution = new_solution |
| # Time Complexity - O(n) where n integer passed through fibonacci(n) method | ||
| # Space Complexity - ? (should be O(n)); It is O(n) where n is the number of times the method is called and placed on the stack | ||
| # Hint, you may want a recursive helper method | ||
| def fibonacci(n) |
| # Space Complexity - ? | ||
| # Time Complexity - O(n) where n is equal to the number of digits in the n-number passed in the method | ||
| # Space Complexity - O(n) where n is equal to the number of times the super_digit method is placed on the call stack | ||
| def super_digit(n) |
| # Space Complexity - ? | ||
| # Time Complexity - O(n) where n is equal to the number of digits in the n-number passed in the super_digit method or the number of digits in the result-number passed in the super_digit method. | ||
| # Space Complexity - O(n) where n is equal to the number of times the suger_digit method is placed on the call stack | ||
| def refined_super_digit(n, k) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.