Space - Hala

[halahaddad1]

No description provided.

[CheezItMan]

Your solutions work but have less than ideal time complexity. Think about how you can use a hash to solve them.

Take a look at my comments and let me know if you have any questions.

[CheezItMan]

.include? is an O(n) operation and since you have this in an O(m) loop... this becomes O(n * m)

Think about how you could use a hash to make this faster.

[CheezItMan]

This works, but it's O(n * m) in time complexity. Using a hash you can get this to O(n + m) time complexity which is much better.

I encourage you to think about how to do this.

[CheezItMan]

.count has an O(n) loop, so this is an O(n^2) algorithm... Another place a hash could make this better.

Suggested change

	string.each_char do |char|
	count[char]= string.count(char)
	end
	string.each_char do |char|
	count[char]= count[char] ? count[char] + 1 : 1
	end

[CheezItMan]

This is another instance where you've brute-forced the solution. It works, but a hash would make this much better.

I encourage you to think a bit further on this.