Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Good work, you hit most of all the learning goals here. Well done.
Take a look at my comments and let me know if you have any questions.
| crossroads = [] | ||
|
|
||
| list1.each do |n| | ||
| crossroads << n if list2.include?(n) != false |
There was a problem hiding this comment.
.include is an O(n) operation and you have this in a loop...
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def intersection(list1, list2) |
There was a problem hiding this comment.
This works, but it's O(n * m) in time complexity. Using a hash you can get this to O(n + m) time complexity which is much better.
I encourage you to think about how to do this.
| def palindrome_permutation?(string) | ||
| raise NotImplementedError, "palindrome_permutation? not implemented" | ||
| end No newline at end of file | ||
| while string.empty? |
There was a problem hiding this comment.
while?
| while string.empty? | |
| if string.empty? |
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def palindrome_permutation?(string) |
| perm = string1.chars | ||
| mutant = string2.chars | ||
| mindflayer = {} |
There was a problem hiding this comment.
I like DND too, but these aren't the best variable names.
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def permutations?(string1, string2) |
There was a problem hiding this comment.
This works only if the count of each letter is the same. It returns true however for heelo and hello.
2 participants
Apologies that this is late--meant to submit around 6:30, and I just remembered I forgot to do the PR step.