Skip to content

space- leah && lauren#16

Open
francestremere wants to merge 5 commits intoAda-C13:masterfrom
francestremere:master
Open

space- leah && lauren#16
francestremere wants to merge 5 commits intoAda-C13:masterfrom
francestremere:master

Conversation

@francestremere
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? method signature(name + parameters) and the block
What are the advantages of using git when collaboratively working on one code base? Version control makes working remotely easier and also we don't have to touch each other's computers (gross) which helps keeps the peace. Git also makes it easy to look back at previous versions and revert to code that was functioning.
What kind of relationship did you and your pair have with the unit tests? We used them frequently, especially when we were debugging. We high fived with passes.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We use min_by, max_by, uniq. We used min_by and max_by to determine the highest score and tie-breaker, we used uniq to determine if there was a tie.
What was one method you and your pair used to debug code? We used the built in debugger in VS Code and it's amazing thank you. We also talked to Tim, who helped us sort out steps to get through some tricky logic.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We talked about how it's very important to come to a pair project with self-care strategies figured out for yourself, but also that advocating for a reset to make sure that both of us are on the same page about the problem and our approach is ALWAYS a good idea.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages Technically there are 3+ commits but didn't start committing until the project was practically done. I see that you realized that based on your message. Haha. Definitely worth committing throughout your work on the project in the future :)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever ✅ Love splitting out tie_breaker into it's own method!
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants