Time - Yoyo - Nataliya

[ydunbar]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	method signature: method name, and parameters, and method block.
What are the advantages of using git when collaboratively working on one code base?	All collaborators can simultaneously access code and make changes. Merge is helpful for when there are conflicting commits.
What kind of relationship did you and your pair have with the unit tests?	We ran tests together and we both looked at the test output to determine what next steps to take to pass tests. We also created two new tests together for Wave 5.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	We used .count to check whether a player's inputted word had more instances of a letter than those available in the drawn hand. And we used .min_by to find the smallest word in case of a tie. These methods helped us to keep our code concise.
What was one method you and your pair used to debug code?	We printed the value of some variables to check that they were as expected. We carefully read the results of the tests to determine where errors were happening in our code.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We agree that we both need to work on our understanding of syntax and our knowledge of different methods. We discussed our communication styles and agreed that we would approach this project by being direct and honest with each other.

[jmaddox19]

Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	Technically there are 3+ commits but didn't start committing until the project was practically done. Definitely worth committing throughout your work on the project in the future :)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Great work!! Very readable and concise.

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅ The comments definitely help :)
Concise	✅
Logical/Organized	✅