Space - Chelsea #43
Open
Space - Chelsea #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalculatorMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
SummaryNicely done, you hit all the learning goals here. Well done, this makes a good start at Ada. |
CheezItMan
reviewed
Feb 7, 2020
| end | ||
|
|
||
| def valid_number(number) | ||
| alphabet_array = [*'a'..'z', *'A'..'Z'] # https://stackoverflow.com/questions/4846853/generate-array-of-all-letters-and-digits |
| alphabet_array = [*'a'..'z', *'A'..'Z'] # https://stackoverflow.com/questions/4846853/generate-array-of-all-letters-and-digits | ||
| operator_array = ["!","@","#","$","%","^","&","(",")","[","]","{","}","?","_","``","~","|","<",">",",",";",":","=","+","-","*","/"] | ||
| if number == 0 && number.to_i.to_s == number #for when people truly put in 0 | ||
| return "yes" |
There was a problem hiding this comment.
It would probably be better to return true if it is a number, and false if it isn't.
| end | ||
|
|
||
| case operator | ||
| when "add","+" |
There was a problem hiding this comment.
In general the when should be indented under the case statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Calculator
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:
Reflection