Skip to content

Space - Lee#45

Open
theomoondev wants to merge 1 commit intoAda-C13:masterfrom
theomoondev:master
Open

Space - Lee#45
theomoondev wants to merge 1 commit intoAda-C13:masterfrom
theomoondev:master

Conversation

@theomoondev
Copy link

Assignment Submission: Calculator

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:

Reflection

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? My code style has proper indentation (although I noticed that Github's default tab size is 8, which might mess up the indentation). I think the spacing, variable names, and comments make sense. The readability is good. Sometimes I am not sure if I should add a break between lines of code that assign values to variables (e.g., when the user is prompted for two numbers).
How did your code keep track of user input? It checked whether the user inputs were valid (using methods and a while loop) and assigned the verified inputs to variables.
How did your code determine what operation to perform? My code executes a case statement that checks the value assigned to a variable called operation; depending on which operator the user chose, the operator variable is assigned with a symbol that best represents the operator, and the result variable is assigned the output of num_1 + num_2, num_1 - num_2, etc.
What opportunities exist to create small methods for this project? I could probably find a way to add the while loop (line 56) to the verify_num method. I could also create a method that allows the user to make more calculations without having to restart the program.
In the next project, what would you change about your process? What would you keep doing? I spend most of my project time working on optional enhancements, which leaves little time for sleep, preview, and comprehension questions. In the next project, I will work on getting a better balance.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses conditionals (if/else/elsif) ✔️
Correctly uses loops (while/until) ✔️
Correctly uses gets.chomp ✔️
Correctly uses variables ✔️
Correctly creates and uses custom methods ✔️

Functional Requirements

Functional Requirement yes/no
User can input two numbers and an operator and perform addition ✔️
User can input in two numbers and an operator and can perform subtraction ✔️
User gets feedback from the CLI when attempting to divide by zero, and the program does not give an error ✔️

Overall Feedback

Great work! I love that you researched a way to prettify floats and cited your source!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 3+ in Code Review && 2+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants