Open
Conversation
CalculatorMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
SummaryOverall there's some good work here. You hit the learning goals. This makes a good start at Ada. One thing I strongly suggest is that you run the code and test things a few times before submission. You would have caught your errors in the input validation then. |
CheezItMan
reviewed
Feb 6, 2020
Comment on lines
+8
to
+10
| 4.times do |i| | ||
| puts "#{i+1}. #{arr[i]}" | ||
| end |
| options = ["add", "+","subtract","-","multiply","*","divide","/"] | ||
| if !options.include?(x) | ||
| puts "wrong input! try again!" | ||
| x = gets.chomp |
|
|
||
| puts "what numbers would you like to calculate" | ||
| a= gets.chomp.to_i | ||
| while !options.include?(a==Integer) |
There was a problem hiding this comment.
This doesn't work.
Suggested change
| while !options.include?(a==Integer) | |
| while a != a.to_s.to_i |
|
|
||
|
|
||
| puts "what numbers would you like to calculate" | ||
| a= gets.chomp.to_i |
There was a problem hiding this comment.
Don't use variable names like a. Instead use meaningful variable names like first_num
|
|
||
| def operator(m,n,y) | ||
| case y | ||
| when "add","+" |
There was a problem hiding this comment.
The when should be indented under the case.
| end | ||
|
|
||
| def operator(m,n,y) | ||
| case y |
There was a problem hiding this comment.
The case should be indented under the method here.
| a=gets.chomp.to_i | ||
| end | ||
| b= gets.chomp.to_i | ||
| while !options.include?(b==Integer) |
There was a problem hiding this comment.
Suggested change
| while !options.include?(b==Integer) | |
| b != b.to_s.to_i``` |
| end | ||
| b= gets.chomp.to_i | ||
| while !options.include?(b==Integer) | ||
| puts "wrong input! Please enter an Integer .. try again!" |
There was a problem hiding this comment.
Suggested change
| puts "wrong input! Please enter an Integer .. try again!" | |
| puts "wrong input! Please enter an Integer .. try again!" | |
| b = gets.chomp.to_i |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Calculator
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:
Reflection