Open
Conversation
CheezItMan
reviewed
Sep 15, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, you have all the solutions working. You can do things a bit more efficiently using hashes a bit more. This is something to practice a bit as you prepare for interviews.
Comment on lines
+4
to
7
| # Time Complexity: O(n2) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
👍 This works, but you can do better by sorting the words and using the sorted letters as keys for all the anagrams
|
|
||
| numHash.keys.each do |num| | ||
| if returnList.length < k | ||
| returnList<< num |
There was a problem hiding this comment.
Suggested change
| returnList<< num | |
| returnList<< num |
| numHash = {} | ||
| returnList = [] | ||
| list.each do |num| | ||
| if numHash.keys.include?(num) |
There was a problem hiding this comment.
Can be simplified
Suggested change
| if numHash.keys.include?(num) | |
| unless numHash[num].nil? |
Comment on lines
+32
to
34
| # Time Complexity: O(n2) | ||
| # Space Complexity: O(n) | ||
| def top_k_frequent_elements(list, k) |
There was a problem hiding this comment.
Your solution has 3 loops which each run n times. It also sorts the array. So the method is O(n log n) in time complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions