Open
Conversation
CheezItMan
reviewed
Sep 16, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad Diana, you hit the learning goals here. Well done. You do have some work to do on space/time complexity. See my comments on these and let me know what questions you have.
Comment on lines
+4
to
7
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
👍 , however you have O(n) space complexity.
| array_num_hash = num_hash.to_a | ||
|
|
||
| # sort by occurences | ||
| sorted_array_num_hash = array_num_hash.sort_by {|num| -num[1]} |
There was a problem hiding this comment.
just noting this is an O(n log n) operation.
Comment on lines
+26
to
28
| # Time Complexity: O(n^2) in worst case because of the sorting to be done | ||
| # Space Complexity: O(1) | ||
| def top_k_frequent_elements(list, k) |
There was a problem hiding this comment.
You have an O(n log n) time complexity algorithm which is pretty good and O(n) space complexity because you're making a hash and an array both proportional to the size of the original list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
- Hash values are uniformly distributed
- Keys that are close have hash values that are far apart
- Hashing appears to be random