Open
Conversation
CheezItMan
reviewed
Sep 24, 2020
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad Haben, they both work. Your top_k_elements works, but uses an O^2 solution. I encourage you to think of an alternative, sorting is one way, there is also another even better.
Comment on lines
+6
to
8
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def grouped_anagrams(strings) |
Comment on lines
+42
to
45
| # Time Complexity: O(n^2) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def top_k_frequent_elements(list, k) |
There was a problem hiding this comment.
👍 Could you use a sort to improve the time complexity to O(n log n) or better?
| # each element in another, sorted based on descending # freqency | ||
| elements = [] | ||
| elements_frequency = [] | ||
| hash1.each do | key, frequency | |
There was a problem hiding this comment.
Could you sort the hash key-value pairs here or select the max k elements instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions