Space - Suely

[SuelyBarreto]

Assignment Submission: Hotel

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
What was a design challenge that you encountered on this project?	My initial design was more complex with more classes like Room, Customer, etc., but i decided to use the scaffolding which was much simpler.
What was a design decision you made that changed over time over the project?	Once I decided to use the scaffolding, the only change was to create the Block class.
What was a concept you gained clarity on, or a learning that you'd like to share?	The concept of Composition was hard to learn. This project has helped a lot with that. In terms of learning, this project has been the best for me so far.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	When testing the date range overlap, there were simple cases like when there was clearly no overlap possible at all.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	When testing the date range overlap, tests involving an overlap on the end date were tricky. They looked like an overlap but there were not.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I loved it! I will definitely use it moving forward.

[jmaddox19]

Hotel

Section 1: Major Learning Goals

Criteria	yes/no, and optionally any details/lines of code to reference
Practices SRP by having at least two separate classes with distinct responsibilities, and test files for these two classes	✔️
Overall, demonstrates understanding instance variables vs. local variables. (There aren't unnecessarily too many instance variables, when it should be a local variable)	✔️
For each test file, tests demonstrate an understanding of instantiating objects properly, and using Arrange-Act-Assert	✔️
Practices pseudocode and TDD, and reflected on it by filling out the reflection questions	✔️
Practices git with at least 15 small commits and meaningful commit messages	✔️

Section 2: Code Review and Testing Requirements

Criteria	yes/no, and optionally any details/lines of code to reference
There is a class that represents a reservation, and a second class that holds/manages a collection of reservations through composition (instance variable)	✔️
The logic for checking if a reservation's date overlaps with another reservation's date is complex logic that is separated into method(s) (and potentially class(es))	✔️ No but only because it's clever and simple
The logic for checking if a reservation's date overlaps with another reservation's date has unit tests	✔️
All of the given tests run and pass	✔️
A test coverage tool is installed and used, and shows 95% test coverage	✔️100%!

Section 3: Feature Requirements

Feature Requirement: There is a method that...	yes/no
gives back a list of rooms, and it's tested	✔️
creates a specific reservation for a room for a given date range, and it has nominal test cases	✔️
creates a specific reservation for a room for a given date range, and it tests an edge case, such as no available room, or invalid date range	✔️
gives back a list of reservations on a given date. Its tests include a test that makes several reservations for a given date	✔️
calculates the total price for a reservation	✔️
gives back a list of available rooms for a given date range, and it has nominal test cases	✔️
gives back a list of available rooms for a given date range, and it has edge test cases, such as no available room, or invalid date range
creates a block of rooms	✔️
reserves a room from a block	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ total in all sections	✔️
Yellow (Approaches Standards)	9-13 total in all sections
Red (Not at Standard)	0-8 total in all sections, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Additional Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you tested your code so thoroughly! And not just for one class: All of your code!! This is going to prove to be invaluable practice 👏

I do see some room for improvement around...

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[jmaddox19]

I hope you know writing this file and setting up a command-line interface was above and beyond what we asked for.
But glad you were able to do it. :)

[jmaddox19]

So clever!!!!