Space - Stephanie by stephaniejmars · Pull Request #31 · Ada-C13/hotel

stephaniejmars · 2020-03-09T14:54:58Z

Assignment Submission: Hotel

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
What was a design challenge that you encountered on this project?	My design definitely evolved. I was excited to do my own design, but whenever I had to ask for help with something people I asked would question my design, and sometimes it was helpful, but sometimes it was a waste of time, and I wasn't getting the help I needed on simple syntax type issues I was having.
What was a design decision you made that changed over time over the project?	I wanted Reservation to build reservations, but in the end I decided it would be a reservation and not have a reservation. Then I decided it would go in Manager, and eventually making a reservation ended up in Room.
What was a concept you gained clarity on, or a learning that you'd like to share?	I learned a little more about Has vs Is. I still need clarity on attr_reader, Let, testing pieces within methods instead of just the outcome.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	I tested if a room is available on a date that was months away from any of its bookings.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	I tested if a room is booked 4/1-4/2 and 4/3-4/7, it should be available to book 4/2-4/3 (and it wasn't, so I fixed it).
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It is hard at first when you don't funny understand the syntax of the test, but it was helpful to do just small pieces of code and test at a time. Make sure its passing before I moved on.

…t on Manager.

… Room.

…g with check availablity.

…able methods.

…oom. Changed date_range to is_available_range

….in progress.

…g, create rooms updated and working.

…ger.

jmaddox19 · 2020-03-17T19:40:16Z

Hotel

Section 1: Major Learning Goals

Criteria	yes/no, and optionally any details/lines of code to reference
Practices SRP by having at least two separate classes with distinct responsibilities, and test files for these two classes	✔️
Overall, demonstrates understanding instance variables vs. local variables. (There aren't unnecessarily too many instance variables, when it should be a local variable)	There seem to be some possible gaps in understanding here. See my inline comments for more details.
For each test file, tests demonstrate an understanding of instantiating objects properly, and using Arrange-Act-Assert	✔️
Practices pseudocode and TDD, and reflected on it by filling out the reflection questions	✔️
Practices git with at least 15 small commits and meaningful commit messages	✔️

Section 2: Code Review and Testing Requirements

Criteria	yes/no, and optionally any details/lines of code to reference
There is a class that represents a reservation, and a second class that holds/manages a collection of reservations through composition (instance variable)	✔️
The logic for checking if a reservation's date overlaps with another reservation's date is complex logic that is separated into method(s) (and potentially class(es))	✔️
The logic for checking if a reservation's date overlaps with another reservation's date has unit tests	✔️
All of the given tests run and pass	✔️
A test coverage tool is installed and used, and shows 95% test coverage	✔️ 99%!!

Section 3: Feature Requirements

Feature Requirement: There is a method that...	yes/no
gives back a list of rooms, and it's tested	✔️
creates a specific reservation for a room for a given date range, and it has nominal test cases	✔️
creates a specific reservation for a room for a given date range, and it tests an edge case, such as no available room, or invalid date range	✔️
gives back a list of reservations on a given date. Its tests include a test that makes several reservations for a given date	✔️
calculates the total price for a reservation	✔️
gives back a list of available rooms for a given date range, and it has nominal test cases	✔️
gives back a list of available rooms for a given date range, and it has edge test cases, such as no available room, or invalid date range
creates a block of rooms
reserves a room from a block

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ total in all sections	✔️
Yellow (Approaches Standards)	9-13 total in all sections
Red (Not at Standard)	0-8 total in all sections, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Additional Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you setup readable and logical relationships between classes!

I do see some room for improvement around variable naming, instance variables, and readers/writers. Please see the inline comments for more details.

Please reach out to me if any of my comments don't give enough detail or if you could use more explanation!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable	✅
Concise
Logical/Organized	✅

jmaddox19 · 2020-03-17T18:53:40Z

lib/manager.rb

+    attr_writer
+    attr_accessor    


Just so you know, these lines aren't needed when you don't have any attributes you want to list for them.

jmaddox19 · 2020-03-17T18:54:58Z

lib/manager.rb

+    attr_writer
+    attr_accessor    
+
+    def initialize(num: 20)


This is a great way to set this up! A great example of where input params to a constructor can be totally different than the instance variable(s)!

jmaddox19 · 2020-03-17T18:55:16Z

lib/manager.rb

+      end
+    end
+
+    def self.create_rooms(num: 20)


Cool that you made this its own method!

jmaddox19 · 2020-03-17T19:22:44Z

lib/manager.rb

+
+    def res_by_room(rm_num, start_date, end_date)
+      res_array = []
+      @found_room = @all_rooms.find {|room| room.rm_num}


This could/should be a local variable rather than an instance variable since it is only used within this one method.
That would be changed by just removing the @

Suggested change

@found_room = @all_rooms.find {|room| room.rm_num}

found_room = @all_rooms.find {|room| room.rm_num}

jmaddox19 · 2020-03-17T19:24:14Z

lib/manager.rb

+
+module Hotel
+  class Manager
+    attr_reader :num, :all_rooms, :rm_reservations, :recloc


This should only define readers for instance variable of the Hotel class. The only of these 4 that is an instance variable of Hotel is all_rooms.

Suggested change

attr_reader :num, :all_rooms, :rm_reservations, :recloc

attr_reader :all_rooms

I imagine you might understand that and just forgot to update this line.

jmaddox19 · 2020-03-17T19:26:06Z

lib/reservation.rb

+      rm_num: nil, 
+      cost_per_day: 200, 
+      total_cost: nil, 
+      recloc: nil)


I'm having trouble understanding what this variable represents. It's best to name variables in such a way that their purpose is clear to anyone who might read the code.

jmaddox19 · 2020-03-17T19:26:49Z

lib/reservation.rb

+
+module Hotel
+  class Reservation
+    attr_reader :start_date, :end_date, :rm_num, :cost_per_day, :total_cost, :recloc


These all correspond to instance variables. Great!

jmaddox19 · 2020-03-17T19:39:32Z

lib/manager.rb

+    def find_total_cost(rec_loc)
+      res = ""
+      @all_rooms.each do |room|
+         if room.rm_reservations.find{|res| res.recloc[:recloc] == rec_loc}.class == Hotel::Reservation


This is just slightly too indented.
I use this handy VSCode plugin called "indent-rainbow" to make that really easy to notice.

stephaniejmars added 27 commits March 2, 2020 14:01

set up

7465da1

added room initialize & tests

40e66fb

method create_rooms added with test

f57b318

updated to take out cost

1388482

initalize begun, not completed

305982b

tests started - not complete.

4831bfd

updated to take out cost

214e1d5

initalize - not complete

380c6c1

initalize - not completed

60f858d

moved building rooms to Manager. Added recloc and corrected total_cos…

237e3e1

…t on Manager.

setting up to check availablity in Reservation. added rm res array to…

e70bbe9

… Room.

pseudo code to change layout, booking res will be in Room class, alon…

661e774

…g with check availablity.

building code in room and manager to complete book_room, and is_avail…

79e36e2

…able methods.

added date_range method

65526d1

updated book_res in Manager class to match with new range method in R…

27b3415

…oom. Changed date_range to is_available_range

added overlap method. And it works! lol

fd154c1

pseudo set up for manager methods, res_by_room, res_by_date, total_cost

82fe8cd

breaking down initialize and create_rooms, found error in intialize..…

54b5825

….in progress.

initalize updated to take different parameters, show all rooms workin…

6128351

…g, create rooms updated and working.

added return in book_room, correctly book rooms test working now.

c848cca

moved simplecov up to work correctly

59d2694

book res updated and test running.

a28ab4e

added in rooms has_res_by_date method, and res_by_room method in Mana…

bce7423

…ger.

res_by_date and tests completed.

d292dd4

fixed find_total cost and tests, added new parameter in book_room.

4f1dd3a

deleted overlap method in room, fixed rooms_available_by_date in mana…

2214448

…ger.

fixed indents and comments.

6ee69f6

jmaddox19 reviewed Mar 17, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Space - Stephanie#31

Space - Stephanie#31
stephaniejmars wants to merge 27 commits intoAda-C13:masterfrom
stephaniejmars:master

stephaniejmars commented Mar 9, 2020

Uh oh!

jmaddox19 commented Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

jmaddox19 Mar 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	@found_room = @all_rooms.find {\|room\| room.rm_num}
	found_room = @all_rooms.find {\|room\| room.rm_num}

	attr_reader :num, :all_rooms, :rm_reservations, :recloc
	attr_reader :all_rooms

Conversation

stephaniejmars commented Mar 9, 2020

Assignment Submission: Hotel

Reflection

Uh oh!

jmaddox19 commented Mar 17, 2020

Hotel

Section 1: Major Learning Goals

Section 2: Code Review and Testing Requirements

Section 3: Feature Requirements

Overall Feedback

Additional Feedback

Code Style Bonus Awards

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants