Time - Corinna

.gitignore

@@ -1,3 +1,5 @@
+
+
 *.gem
 *.rbc
 /.config
@@ -48,3 +50,4 @@ build-iPhoneSimulator/
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc
+coverage

lib/date.rb

@@ -0,0 +1,22 @@
+require 'date'
+
+require_relative 'frontdesk.rb'
+require_relative 'reservation.rb'
+
+module Hotel
+  class DateRange
+
+      def contains(date)
+        (date >= @start_date && date < @end_date) ? true : false
+      end
+
+      def no_conflict?(new_start, new_end)
+        if @end_date == new_start || new_start > @end_date || new_end < @start_date || new_end == @start_date
+          return true
+        elsif new_start >= @start_date && new_start < @end_date || new_end > @start_date
+          return false
+        end
+      end
+
+  end
+end

lib/frontdesk.rb

@@ -0,0 +1,85 @@
+require 'date'
+
+require_relative 'date.rb'
+require_relative 'reservation.rb'
+
+module Hotel
+  class FrontDesk
+
+    attr_reader :all_reservations, :rooms
+
+    def initialize
+      @all_reservations = all_reservations || []
+      @rooms = [*1..20]
+    end
+
+    def assign_room(new_reservation)
+      taken_rooms = []
+      all_rooms = @rooms.dup
+      @all_reservations.each do |reservation|
+        reservation.no_conflict?(new_reservation.start_date, new_reservation.end_date) ? taken_rooms << reservation.assigned_room : next
+      end
+      room_to_assign = (all_rooms - taken_rooms.flatten)
+      assigning = room_to_assign.sample(new_reservation.num_rooms)
+      taken_rooms.include?(assigning)
+        assigning = room_to_assign.sample(new_reservation.num_rooms)
+    end
+
+    def add_reservation(start_date, end_date, num_rooms)
+      new_reservation = Hotel::Reservation.new(start_date: start_date, end_date: end_date, num_rooms: num_rooms)
+      new_reservation.assigned_room = assign_room(new_reservation)
+      if new_reservation.num_rooms > 1 
+        raise ArgumentError.new("Invalid room reservation request: if you would still like #{num_rooms} rooms please reserve as a block.")
+      end
+      @all_reservations << new_reservation
+    end
+
+    def add_block_reservation(start_date, end_date, num_rooms, discount, block_key)
+      new_reservation = Hotel::Reservation.new(start_date: start_date, end_date: end_date, num_rooms: num_rooms, discount: discount, block_key: block_key)
+      new_reservation.assigned_room = assign_room(new_reservation)
+      if new_reservation.num_rooms > 1 
+        new_reservation.block = :BLOCK
+      elsif new_reservation.num_rooms == 1
+        raise ArgumentError.new("Invalid room reservation request: if you would still like #{num_rooms} room please reserve as a single.")
+      end
+      @all_reservations << new_reservation
+    end
+
+    def find_reservation_by_date(date)
+      @all_reservations.select {|reservation| reservation.contains(date)}
+    end
+
+    def find_available_room_by_date(date)
+      taken = []
+      all_rooms = @rooms.dup
+      booked = find_reservation_by_date(date)
+      booked.map {|reservation| taken << reservation.assigned_room}
+      available_rooms = (all_rooms - taken.flatten)
+    end
+
+    def find_block_by_block_key(date, block_key)
+      reservations_on_day = find_reservation_by_date(date)
+      in_block = reservations_on_day.select {|reservation| reservation.block_key == block_key}
+      return in_block
+    end
+
+    def update_block(date, block_key)
+      found_block = find_block_by_block_key(date, block_key)
+      if found_block[0].num_rooms == 0
+        raise ArgumentError.new("Invalid room reservation request: all rooms in this block have been reserved.")
+      else
+        found_block[0].num_rooms -= 1
+      end
+      return found_block[0]
+    end
+
+    # * I can reserve a specific room from a hotel block
+    # * I can only reserve that room from a hotel block for the full duration of the block
+    def reserve_from_block(date, block_key)
+      book_room = update_block(date, block_key)
+      book_room.assigned_room = book_room.assigned_room[0]
+      book_room.num_rooms = 1
+      return book_room
+    end
+  end
+end

lib/reservation.rb

@@ -0,0 +1,53 @@
+require 'date'
+
+
+require_relative 'frontdesk.rb'
+require_relative 'date.rb'
+
+module Hotel
+  class Reservation < DateRange
+    attr_accessor :start_date, :end_date, :num_rooms, :assigned_room, :discount, :block, :block_key
+
+    COST = 200.00
+
+    def initialize(start_date:, end_date:, num_rooms:, discount: nil, block: :SINGLE, block_key: nil)
+      @start_date = start_date 
+      @end_date = end_date 
+      @num_rooms = num_rooms
+      @assigned_room = []
+      @discount = discount
+      @block = block
+      @block_key = block_key
+
+      raise ArgumentError.new("Invalid times: #{@start_date} comes after #{@end_date}") if (@start_date > @end_date || @start_date == @end_date)
+
+      raise ArgumentError.new("Invalid room request: provided #{@num_rooms} instead of an Integer") if @num_rooms.class != Integer
+
+      raise ArgumentError.new("Invalid room request: requested #{@num_rooms} rooms, #{@num_rooms-5} too many.") if @num_rooms > 5
+
+      raise ArgumentError.new("Invalid block key. Not valid for single room reservations") if @num_rooms == 1 && block_key != nil
+
+      raise ArgumentError.new("Status and room argument: #{@num_rooms} room, should not be noted as a block") if (@num_rooms == 1 && @block == :BLOCK)
+
+      raise ArgumentError.new("Invalid status. Please choose: single or block.") unless [:SINGLE, :BLOCK].include? block
+    end
+
+    def total_cost
+      @num_rooms == 1 ? final_bill = (@end_date - @start_date)*@num_rooms*COST : final_bill = (@end_date - @start_date)*@num_rooms*COST*(1 - @discount)
+      return final_bill
+    end
+
+    #DateRange class originally lived here as methods
+    # def contains(date)
+    #   (date >= @start_date && date < @end_date) ? true : false
+    # end
+
+    # def conflict?(new_start, new_end)
+    #   if new_start >= @start_date && new_start < @end_date || new_end > @start_date
+    #     return false
+    #   elsif @end_date = new_start || new_start > @end_date || new_end < @start_date || new_end == @start_date
+    #     return true
+    #   end
+    # end
+  end
+end

refactors.txt

@@ -0,0 +1,17 @@
+A few things to change moving forward:
+
+Tighter code
+  1. Refactor code with Enumerable methods where possible
+  2. Consider where ternary format could be used
+  3. Reconsider where other helper methods could be created
+
+Block class
+  1. Consider pulling out a separate Block class and using Reservation as it's super class -- that way, if you used super in intitialize, you'd only have to add on block: and block_key:
+
+DateRange class
+  1. Reconsider DateRange as it's own class (has no independent behaviors)
+
+Tighten up variable naming conventions
+  1. Make sure method naming conventions follow a pattern
+  2. Make sure method naming conventions logically build on one another IE reserve_from_block relies on update_block
+  3. Review and update variable names for clarity and replication

test/date_test.rb

@@ -0,0 +1,40 @@
+require_relative "test_helper"
+
+describe "DateRange" do
+
+  describe "contains" do
+    before do
+      @reservation = Hotel::Reservation.new(start_date: Date.new(2020, 5, 1), end_date: Date.new(2020, 5, 4), num_rooms: 1)
+    end
+
+    it "returns true if requested date is contained in reservation dates" do
+      expect(@reservation.contains(Date.new(2020, 5, 2))).must_equal true
+    end
+
+    it "returns true if requested date is first day in reservation dates" do
+      expect(@reservation.contains(Date.new(2020, 5, 1))).must_equal true
+    end
+
+    it "returns false if requested date is last day in reservation dates" do
+      expect(@reservation.contains(Date.new(2020, 5, 4))).must_equal false
+    end
+  end
+
+  describe "conflict?" do
+    before do
+      @reservation = Hotel::Reservation.new(start_date: Date.new(2020, 5, 1), end_date: Date.new(2020, 5, 4), num_rooms: 1)
+    end
+
+    it "returns true if requested dates are contained in current reservation dates" do
+      expect(@reservation.no_conflict?(Date.new(2020, 5, 2), Date.new(2020, 5, 4))).must_equal false
+    end
+
+    it "returns true if requested start date is the same as current end date" do
+      expect(@reservation.no_conflict?(Date.new(2020, 5, 4), Date.new(2020, 5, 5))).must_equal true
+    end
+
+    it "returns false if requested start date is earlier than current end date" do
+      expect(@reservation.no_conflict?(Date.new(2020, 5, 2), Date.new(2020, 5, 5))).must_equal false
+    end
+  end
+end