Open
Conversation
CheezItMan
reviewed
Sep 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work, you hit the requirements here and the extras as well. Take a look at my few comments and let me know what questions you have, very well done.
| # Space Complexity: O(1) | ||
| def visit | ||
| raise NotImplementedError | ||
| curernt = @head |
There was a problem hiding this comment.
Suggested change
| curernt = @head | |
| current = @head |
| raise NotImplementedError | ||
| return nil if @head.nil? | ||
| current = @head | ||
| previous_node = nil |
There was a problem hiding this comment.
You don't need this variable.
Suggested change
| previous_node = nil |
Comment on lines
+25
to
27
| # Time Complexity: 0(1) | ||
| # Space Complexity: 0(1) | ||
| def add_first(value) |
Comment on lines
+40
to
42
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
55
to
57
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+108
to
110
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+123
to
125
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
133
to
136
| # method to delete the first node found with specified value | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def delete(value) |
There was a problem hiding this comment.
👍 , but the time complexity is O(n) and space O(1)
Comment on lines
+158
to
160
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Comment on lines
207
to
209
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first |
There was a problem hiding this comment.
The time and space complexity is O(1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.