Open
Conversation
CheezItMan
reviewed
Sep 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done, one bug with visit, but let me know what questions you have. Overall well done!
Comment on lines
+21
to
+23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+30
to
+32
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
+46
to
+48
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+59
to
+63
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+96
to
+98
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+111
to
+114
| # method to print all the values in the linked list | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def visit |
There was a problem hiding this comment.
This method should be printing out all the values of the linked list. You're doing something odd here:
This is assigning current to it's data and if that's truthy, you're then crashing the program by trying to access current.data because current has been assigned to current.data previously.
if current = current.data
return current.data
end
Comment on lines
+122
to
+125
| # method to delete the first node found with specified value | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
Comment on lines
+146
to
+148
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.