Open
Conversation
CheezItMan
reviewed
Sep 8, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall very nice work, you hit the learning goals and some of the optionals. Well done.
Comment on lines
+21
to
23
| # Time Complexity: O(1) bc it only adds one thing regardless of how big the list is | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+24
to
+28
| if @head.nil? | ||
| @head = Node.new(value) | ||
| else | ||
| @head = Node.new(value, @head) | ||
| end |
There was a problem hiding this comment.
Could be simplified as:
Suggested change
| if @head.nil? | |
| @head = Node.new(value) | |
| else | |
| @head = Node.new(value, @head) | |
| end | |
| @head = Node.new(value, @head) |
Comment on lines
+33
to
35
| # Time Complexity: O(n) because worst case it needs to run through all items in list | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
50
to
52
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+70
to
72
| # Time Complexity: O(n) bc it has to run through every item | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+128
to
130
| # Time Complexity: O(n) bc it has to go thru every item on the list | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+142
to
144
| # Time Complexity: O(n) because you could look through entire list before you found specified value | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
Comment on lines
203
to
205
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first |
Comment on lines
211
to
214
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_last(value) |
Comment on lines
228
to
232
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.