Open
Conversation
CheezItMan
reviewed
Sep 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, a few mistakes, notably on space complexity. Take a look at my comments and let me know what questions you have.
Comment on lines
+37
to
39
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def search(value) |
There was a problem hiding this comment.
The space complexity is O(1) because you're not creating a new list as this method runs.
Comment on lines
56
to
58
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+77
to
79
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def find_min |
There was a problem hiding this comment.
👍 , except the space complexity is O(1)
Comment on lines
+97
to
99
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def length |
Comment on lines
+115
to
117
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_at_index(index) |
There was a problem hiding this comment.
What if the length is <= index? You've got to do something to handle that edge case.
| return | ||
| end | ||
|
|
||
| pointer = find_previous(value) |
Comment on lines
+138
to
-77
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def delete(value) | ||
| raise NotImplementedError |
Comment on lines
+202
to
204
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
+210
to
212
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_last(value) |
There was a problem hiding this comment.
👍 , however the time complexity is O(n) because you are traveling to the rear of the list.
Comment on lines
+233
to
235
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_last |
There was a problem hiding this comment.
👍 , but the space complexity is O(1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.