Open
Conversation
CheezItMan
reviewed
Sep 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Liv, you hit all the learning goals here. Well done.
Comment on lines
+21
to
23
| # Time Complexity: o1 | ||
| # Space Complexity: o1 | ||
| def add_first(value) |
Comment on lines
+29
to
31
| # Time Complexity: o1 | ||
| # Space Complexity: o1 | ||
| def search(value) |
Comment on lines
+46
to
48
| #Time Complexity: on | ||
| # Space Complexity: o1 | ||
| def find_max |
Comment on lines
+66
to
68
| # Time Complexity: o(n) | ||
| # Space Complexity: o(1) | ||
| def find_min |
Comment on lines
+86
to
88
| # Time Complexity: on | ||
| # Space Complexity: o1 | ||
| def length |
Comment on lines
+156
to
158
| # Time Complexity: on | ||
| # Space Complexity: o1 | ||
| def reverse |
Comment on lines
178
to
180
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def find_middle_value |
Comment on lines
207
to
209
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first |
Comment on lines
214
to
217
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_last(value) |
Comment on lines
230
to
234
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! So so sorry, I had a family thing that pulled me away for most of the night and I didn't get home until super late. Since it's next-morning late, if this needs to count as my 1 freebie let me know.