Open
Conversation
CheezItMan
reviewed
Sep 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Some issues here and some existing syntax errors. Take a look at my comments and let me know what questions you have.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+24
to
+30
| new_node = Node.new(value) | ||
| if @head.nil? | ||
| @head = new_node | ||
| else | ||
| new_node.next = @head | ||
| @head = new_node | ||
| end |
There was a problem hiding this comment.
This can be simplified as:
Suggested change
| new_node = Node.new(value) | |
| if @head.nil? | |
| @head = new_node | |
| else | |
| new_node.next = @head | |
| @head = new_node | |
| end | |
| @head = Node.new(value, @head) |
Comment on lines
+35
to
37
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
| new_previous = current.next | ||
| new_current = new_previous.next | ||
| new_previous.next = current | ||
| current = new_current |
There was a problem hiding this comment.
Missingend
Suggested change
| current = new_current | |
| current = new_current | |
| end |
Comment on lines
+137
to
+146
| if @head.nil? | ||
| return nil | ||
| end | ||
| previous = @head | ||
| current = @head | ||
| until current.data == value || current.nil? | ||
| previous = current | ||
| current = current.next | ||
| end | ||
| previous.next == current.next |
There was a problem hiding this comment.
You also need a check here to see if value is at the head of the list.
Suggested change
| if @head.nil? | |
| return nil | |
| end | |
| previous = @head | |
| current = @head | |
| until current.data == value || current.nil? | |
| previous = current | |
| current = current.next | |
| end | |
| previous.next == current.next | |
| if @head.nil? | |
| return nil | |
| elsif @head.data == value | |
| @head = @head.next | |
| return | |
| end | |
| previous = @head | |
| current = @head | |
| until current.data == value || current.nil? | |
| previous = current | |
| current = current.next | |
| end | |
| previous.next == current.next |
Comment on lines
+120
to
122
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit |
There was a problem hiding this comment.
👍 , but the space complexity is O(1) because you're not making a new list here.
Comment on lines
+151
to
153
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
There was a problem hiding this comment.
end
Comment on lines
+195
to
197
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
+206
to
208
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_last(value) |
Comment on lines
+223
to
225
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_last |
There was a problem hiding this comment.
👍 , but the time complexity is O(n) since you're traveling to the end of the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.