Open
Conversation
CheezItMan
reviewed
Sep 10, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Katie, thanks for getting this in. It looks solid. I do encourage you to look at reverse and try to find a way to reverse things with better space complexity, just for the practice.
Great job.
Comment on lines
+23
to
25
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+38
to
40
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
53
to
55
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+74
to
76
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+94
to
96
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length |
Comment on lines
113
to
115
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_at_index(index) |
Comment on lines
+134
to
136
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+151
to
153
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
Comment on lines
+182
to
184
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def reverse |
There was a problem hiding this comment.
👍 , interesting how you made a hash of all the nodes then went through that hash again reconstructing the list.
Could you also do it with O(1) space complexity without having to make that hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.