Open
Conversation
CheezItMan
reviewed
Sep 16, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Thanks for getting this in Lola. You hit the main learning goals here. Take a look at my comments, most revolve around time/space complexity. Let me know what questions you have.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+29
to
31
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
There was a problem hiding this comment.
👍 , but why do you think the time complexity is O(1)? You're looping through the list.
Comment on lines
42
to
44
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+59
to
61
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+75
to
77
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length |
Comment on lines
+93
to
95
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+106
to
108
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit |
There was a problem hiding this comment.
👍 , but how is the space complexity O(n), what other data structure are you creating?
Comment on lines
+120
to
122
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def delete(value) |
There was a problem hiding this comment.
👍 , why do you think the space complexity is O(n), what new data structure are you creating?
Comment on lines
+144
to
146
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Comment on lines
192
to
194
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.