Open
Conversation
CheezItMan
reviewed
Dec 9, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Emily, this all works although you're missing some time/space complexity. Well done.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+30
to
32
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+73
to
75
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+96
to
98
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def length |
Comment on lines
+195
to
198
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| # unsure if this method actually works - did a brute force/pseudocode answer and didn't check because no tests | ||
| def find_middle_value |
Comment on lines
+210
to
212
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_nth_from_end(n) |
Comment on lines
+243
to
245
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
+254
to
256
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_last(value) |
| # returns nil if the linked list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.