Open
Conversation
|
Great work on this assignment, Chelsea! Your reflection answers are great, and specific, and detailed and accurate! It looks like from your peer review feedback, that you missed these topics:
Those are topics that I think are important to review, so please please please let me know if you ever want to schedule time to talk through it! Also, if it's helpful, we can definitely make time to review your Slack CLI code in a 1:1. That being said, your reflection answers show that you have understanding on the material, so it seems like just trying to follow the best practices is the next step. Again, let me know, and well done on this! |
tildeee
reviewed
Apr 2, 2020
|
|
||
| 1. Describe a GET request that your project makes, and the high-level description of what it does | ||
| - Answer: | ||
| - Answer:I think unlike many of my classmates I call my get method in the initialize of workspace. This made sense to me at the time because one of the first things I wanted was a list of users and channels. To get that list I used a self.get method and pased in the url. This method uses HTTParty.get to get a response form slack. If the request is no good we raise an error. |
There was a problem hiding this comment.
Just as a small comment: I think that this approach is valid and a totally great way to approach this project.
Author
|
Hi!
I would like to go over testing API calls! Specifically the post message one.
I think I did use the .env correctly but if I didn't you should definitely tell me where I went wrong.
I think I generally understand instance and class methods (though I will admit the more classes there are the more confused I get). I think for this reflection that part got a "no" because my structure was odd. Mostly I am worried about testing API calls.
Is there a good time slot for a zoom chat?
Thanks,
Chelsea
Sent from Outlook<http://aka.ms/weboutlook>
…________________________________
From: dee <notifications@github.com>
Sent: Thursday, April 2, 2020 11:09 AM
To: Ada-C13/slack-cli-reflection <slack-cli-reflection@noreply.github.com>
Cc: ChelseaC13 <chelhelg@outlook.com>; Author <author@noreply.github.com>
Subject: Re: [Ada-C13/slack-cli-reflection] Space - Chelsea (#28)
Great work on this assignment, Chelsea! Your reflection answers are great, and specific, and detailed and accurate!
It looks like from your peer review feedback, that you missed these topics:
* Using the .env file for your Slack token
* Testing API calls
* Using instance methods and class methods
Those are topics that I think are important to review, so please please please let me know if you ever want to schedule time to talk through it! Also, if it's helpful, we can definitely make time to review your Slack CLI code in a 1:1.
That being said, your reflection answers show that you have understanding on the material, so it seems like just trying to follow the best practices is the next step. Again, let me know, and well done on this!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAda-C13%2Fslack-cli-reflection%2Fpull%2F28%23issuecomment-608019353&data=02%7C01%7C%7C99e09bedb5a44e4fab9608d7d7310edf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637214478004585251&sdata=ja6vo%2BqursL8KqPF2iEv1VLKLlzC%2F2WCCj0t%2B4J4tTc%3D&reserved=0>, or unsubscribe<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAODYFTOA4D5T7PEGEF5AD3DRKTIHNANCNFSM4LWH6JKA&data=02%7C01%7C%7C99e09bedb5a44e4fab9608d7d7310edf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637214478004595244&sdata=bFaFXK3M2LdCpwwcPBQQckE%2FDxwL8ocX6xo1MiyFAzU%3D&reserved=0>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.