Time - Vera

feedback.md

@@ -17,7 +17,7 @@
       1. Practices best practices working with APIs. (The .env is not checked into git, and no API token was directly used in the Ruby code without ENV.)
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -26,7 +26,7 @@
       2. Practices error handling with APIs. (For all pieces of code that make an API call, it handles API requests that come back with errors/error status codes appropriately.)
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -35,7 +35,7 @@
       3. Implements inheritance and inheritance idioms. There is a Recipient class. User and Channel inherit from Recipient. In Recipient, there are appropriate methods defined that are used in both User and Channel. Some may be implemented. Some may be template methods.	
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -51,7 +51,7 @@
   </ul>
     </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -60,7 +60,7 @@
     5. Practices instance methods vs. class methods appropriately. (The methods to list all Channels or Users is a class method within those respective classes.)
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -70,7 +70,7 @@
       6. Practices best practices for testing. (The project has and uses VCR mocking when running tests, and can run offline.)
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -80,7 +80,7 @@
       7. Practices writing tests. (The User, Channel, and Workspace classes have unit tests.)	
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -90,7 +90,7 @@
       8. There are also tests for sending messages (the location of these tests may differ, but is likely in Recipient)	
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -100,7 +100,7 @@
       9. Practices git with at least 15 small commits and meaningful commit messages	
    </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 </table>
@@ -118,31 +118,34 @@
    <td>1. As a user of the CLI program, I can <strong>list</strong> users and channels with the commands <code>list users</code> and <code>list channels</code>
    </td>
    <td>
-      yes/no
+      It looks like functionality for this is available (and I assume working), but when I try to run the program from terminal, I get a "cannot load such file" error: Traceback (most recent call last):
+	2: from slack.rb:3:in `<main>'
+	1: from /Users/Ruya/.rvm/rubies/ruby-2.6.5/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
+/Users/Ruya/.rvm/rubies/ruby-2.6.5/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- tty-prompt (LoadError)
    </td>
 
   </tr>
   <tr>
    <td>2. As a user of the CLI program, I can <strong>select</strong> users and channels	with the commands <code>select user</code> and <code>select channel</code>
    </td>
    <td>
-      yes/no
+      ^
    </td>
   </tr>
 
   <tr>
    <td>3. As a user of the CLI program, I can show the details of a selected user or channel	with the command <code>details</code>
    </td>
    <td>
-      yes/no
+      ^
    </td>
   </tr>
 
   <tr>
    <td>4. As a user of the CLI program, when I input something inappropriately, the program runs without crashing. Example commands to try are <code>do_something</code>, or <code>select user</code> followed by <code>Mr. Fakename</code>
    </td>
    <td>
-      yes/no
+      ^
    </td>
   </tr>
 </table>

individual-reflection.md

@@ -9,48 +9,62 @@ Answer the following comprehension questions **within this file.** Write your an
 ### `GET` Request Review
 
 1. Describe a GET request that your project makes, and the high-level description of what it does
-    - Answer:
+    - Answer: File: recipient.rb, line: 18. The GET request info from the SLACK API, Not modify it in any way. It returns an slackError if the info is not found. If the request is successful (200 and parsed_response: "ok") it returns the response in a variable called `resp` as a JSON.
 1. What is the verb of this request?
-    - Answer:
+    - Answer: GET
 1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
+    - Answer: URL: `"https://slack.com/api/users.list` , `"https://slack.com/api/channels.list`
 1. What are the query params (the additional data sent with the request, besides the verb and the path)?
     - Answer: 
 1. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
       # Copy and paste your answer below this comment
-
+        base_url = "https://slack.com/api/"
+        post_url = "#{base_url}channels.list"
+        params = { token: ENV["SLACK_API_TOKEN"] }
+        response: HTTParty.get(pots_url, query: params)
       # Copy and paste your answer above this comment
       ```
 1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
+    - Answer: It saves the response within a variable called `resp`.
 1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+    - Answer: It has a class called `SlackAPIError` to handle the exception with the error and comment: "We encountered a problem".
 
 ### `POST` Request Review
 
 If your project does not make a POST request, read through Wave 3 on the original Slack CLI, and research and answer questions 1, 2, 3, 4, 6, and 7.
 
 1. Describe a POST request that your project makes, and the high-level description of what it does
-    - Answer:
+    - Answer:File: recipient.rb, line: 30. The POST request post to the SLACK API, It sends a message to a specific channel. it returns the response in a variable called `resp` as a JSON when the response is code: 200 and parsed_response: "ok".
 1. What is the verb of this request?
-    - Answer:
+    - Answer: POST
 1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
+    - Answer: URL: `"https://slack.com/api/chat.postMessage"`
 1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
+    - Answer: Headers(Content-Type, charset), and body(token, channel and text).
 1. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
       # Copy and paste your answer below this comment
-
+        base_url = "https://slack.com/api/"
+        post_url = "#{base_url}/chat.postMessage"
+
+        resp = HTTParty.post(post_url,{
+          headers: { 'Content-Type'=> 'application/x-www-form-urlencoded',
+            'charset' => 'utf-8' },
+          body:{
+            token: ENV["SLACK_API_TOKEN"],
+            channel: channel,
+            text: message
+          }
+        })
       # Copy and paste your answer above this comment
       ```
 1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
+    - Answer: It returns the response.
 1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+    - Answer: It does not handle the error/exception.
 
 ## Request & Response Cycle
 
@@ -62,11 +76,11 @@ There are two actors:
 
 Based on the project requirements, when Grace enters "list channels,"
 1. What is the request being made in the program?
-    - Answer: 
+    - Answer: Use GET, endpoint `"https://slack.com/api/channels.list"`
 1. Who is the client?
-    - Answer: 
+    - Answer: Grace computer running `slack.rb`
 1. Who is the server?
-    - Answer: 
+    - Answer: The endpoint `channels.list` it defines request–response message system, expressed in JSON.
 
 ## Part 2: Optional Refactoring
 
@@ -80,4 +94,4 @@ If your reflection inspired you to make minimal changes to your Slack CLI implem
 
 ### Describe your optional Slack CLI changes here
 
-Answer: 
+Answer: For the POST request, I did not take into account when the message could not be sent. I wrote an If statement to handle the error, File: `recipiente.rb` line: 39 to 42. Including `SlackAPIError, "We encountered a problem:` Also I wrote the test for these lines. File: `recipient_test.rb` lines: 52 to 59.