Open
Conversation
…es to refer to Workspace: test_helper.rb and slack.rb. slack.rb also has some code testing out connection to slack api - no tests written yet.
…rresponding tests (passing)
…for far in creating a version of .getlist with no parameters. Wrote passing tests.
…nnel - with passing tests.
…lect channel, details. Added ap to lib_helper.rb
… have one responsibilty - cleaning up use of 'super' to be more understandable and remove a complicated bug. Created .make_query in parent and children to do this.
… + CHannel. This affects #details- which now returns a hash instead of an array.
better encapsulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Slack CLI
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection