Open
Conversation
CheezItMan
reviewed
Feb 28, 2020
CheezItMan
left a comment
There was a problem hiding this comment.
Just looking back a bit based on grocery store. You didn't seem to run this code with ruby main.rb, maybe check in at some point to make sure you know how to run/debug your applications.
| class Planet | ||
| attr_reader :name, :color, :mass_kg, :distance_from_sun_km, :fun_fact | ||
|
|
||
| def initalize(name, color, mass_kg, distance_from_sun_km, fun_fact) |
There was a problem hiding this comment.
Initialize is misspelled
Suggested change
| def initalize(name, color, mass_kg, distance_from_sun_km, fun_fact) | |
| def initialize(name, color, mass_kg, distance_from_sun_km, fun_fact) |
Comment on lines
+21
to
+22
|
|
||
| until directions != "exit" |
There was a problem hiding this comment.
You should also initialize directions, i.e. give it a start value.
Suggested change
| until directions != "exit" | |
| directions = "" | |
| until directions != "exit" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Solar System
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
initializemethod run? What does it do?Hashinstead of an instance of a class?SolarSystemclass used aHashinstead of anArrayto store the list of planets?requirestatements? Which files neededrequires, and which did not? What is the pattern?