Open
Conversation
CheezItMan
reviewed
Sep 15, 2020
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Alicia, you hit the main learning goals here. Well done.
Comment on lines
+9
to
+10
| left_half = ["(", "[", "{"] | ||
| right_half = [")", "]", "}"] |
There was a problem hiding this comment.
Did you know, you could also make a hash where the keys are the open parens and the values are the close parens. That way you wouldn't have to check the indexes like you are.
| @last = 0 | ||
| end | ||
|
|
||
| def enqueue(element) |
| @last = (@last + 1) % @size | ||
| end | ||
|
|
||
| def dequeue |
Comment on lines
29
to
31
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @size | ||
| end |
There was a problem hiding this comment.
Size usually references the number of items in the Queue.
| @@ -1,19 +1,21 @@ | |||
| require_relative './linked_list.rb' | |||
|
|
|||
| class Stack | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions