Open
Conversation
CheezItMan
reviewed
Sep 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done, you hit the main learning goals. Take a look at my comments and let me know what questions you have.
Comment on lines
+35
to
37
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add(key, value) |
There was a problem hiding this comment.
👍 The time/space complexities are O(log n) if the tree is balanced and O(n) if they are unbalanced.
Comment on lines
+59
to
61
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find(key) |
There was a problem hiding this comment.
👍 Similar issues to add with time/space complexities.
Comment on lines
+78
to
80
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder |
Comment on lines
+100
to
102
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder |
Comment on lines
+110
to
+118
| def postorder_helper(node, list) | ||
| if node.nil? | ||
| return list | ||
| end | ||
|
|
||
| list << {key: node.key, value: node.value} | ||
| postorder_helper(node.left, list) | ||
| postorder_helper(node.right, list) | ||
|
|
There was a problem hiding this comment.
This looks like a pre-order method.
Suggested change
| def postorder_helper(node, list) | |
| if node.nil? | |
| return list | |
| end | |
| list << {key: node.key, value: node.value} | |
| postorder_helper(node.left, list) | |
| postorder_helper(node.right, list) | |
| def postorder_helper(node, list) | |
| if node.nil? | |
| return list | |
| end | |
| postorder_helper(node.left, list) | |
| postorder_helper(node.right, list) | |
| list << {key: node.key, value: node.value} | |
Comment on lines
+145
to
147
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def height |
There was a problem hiding this comment.
👍 , the time & space complexities are O(n) for unbalanced trees and O(log n) when the trees are balanced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.