India & Leah - Water

[scottzec]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	Method signature, Parameter(s), Code Block, Return Statement
What are the advantages of using git when collaboratively working on one code base?	It makes it easier to share our code. We also have a detailed track record of every step of our code per Wave, in case we change something and break the code. We are able to work on our individual computers but using the same version of the same code.
What kind of relationship did you and your pair have with the unit tests?	We ran the tests after changing part of code to see how that code changed the outcome of the test. We initially wrote our code following the written description of the different waves and didn't actually change our code incrementally based on each test. We used more for troubleshooting.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	.split (We split an input word string into individual string letters within the array, .include? (We used it to see if each letter a user input was present in the hand of original letters they were given), .delete_at (Each letter that was included, we then deleted it in the copy of the letters_in_hand array to make sure there was no repetition), .length (We used this to compare the lengths of the words to determine what the winning word was)
What was one method you and your pair used to debug code?	We put in many puts and pp and print statements to see the current value of our variables were at different times. We often created sample letters_in_hand or input words to see if they worked for our own understanding of our code before running the tests.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We both reflected that we could have spent more time individually between our meetings each day reviewing the current code so we wouldn't be rusty upon beginning. We were both a bit nervous for our first pair programming, but we communicated and worked smoothly, never getting stuck on anything for too long, and we also made it work really well even with the 9 hour time difference!

[dHelmgren]

Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	✔️
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Quality	Yes?
Perfect Indentation	✅
Concise	✅

[dHelmgren]

you can also do this by using a hash, but this works great!

[dHelmgren]

when you turn in work, it's good to get rid of notes like this!! :)